[CORE] : BUGFIX - prevent Stream closed on concurrent JAR access in TemplateManager#23596
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Apr 21, 2026
Conversation
…Manager When two Gradle tasks run concurrently in isolated classloaders that both point to the same generator JAR, the JVM's JarFileFactory shares a single JarFile between both classloaders. If one classloader is closed/GC'd while the other is still copying a non-template resource (e.g. README.md), the shared JarFile is closed and the other worker's InflaterInputStream throws 'Stream closed'. Two fixes in TemplateManager: 1. getInputStream() now opens a fresh URLConnection with setUseCaches(false) for classpath resources, preventing the underlying JarFile from being shared across classloaders. 2. write() now wraps the InputStream in try-with-resources, fixing the pre-existing resource leak where the stream was never closed after the binary file copy.
Member
|
cc @OpenAPITools/generator-core-team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When two Gradle tasks run concurrently in isolated classloaders that both point to the same generator JAR, the JVM's
JarFileFactoryshares a singleJarFilebetween both classloaders. If one classloader is closed/GC'd while the other is still copying a non-template resource (e.g. README.md), the sharedJarFileis closed and the other worker'sInflaterInputStreamthrows 'Stream closed'.Two fixes in
TemplateManager:getInputStream()now opens a freshURLConnectionwithsetUseCaches(false)for classpath resources, preventing the underlyingJarFilefrom being shared across classloaders.write()now wraps theInputStreamintry-with-resources, fixing the pre-existing resource leak where the stream was never closed after the binary file copy.This bug was introduced by me as a part of the generator speedup in commit c07f3a0:
Before modernization:
GenerateTask.generate()calledDefaultGenerator(...).generate()directly on the Gradle worker thread — same classloader, no isolation, no concurrency issues.After modernization: the task was refactored to use
workerExecutor.classLoaderIsolation(). This runs each task in a separate isolated ClassLoader pointing to the same generator JAR. The JVM'sJarURLConnectionshares a single underlyingJarFileper JAR URL across classloaders (viaJarFileFactory). When two tasks run concurrently and one worker's classloader is torn down, it closes the sharedJarFile, causingInflaterInputStream: Stream closedin the other worker.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Prevents "Stream closed" errors when Gradle tasks access the same generator JAR concurrently by using non-cached URL connections for classpath resources and properly closing streams during file copy. Improves stability for isolated classloaders and stops flaky builds.
URLConnectionwithsetUseCaches(false)for classpath resources to avoid sharedJarFileacross classloaders.write()to close them reliably and fix the leak.Written for commit c30b9a3. Summary will update on new commits.